Messages in this thread | | | Date | Thu, 3 Dec 2020 23:01:45 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [char-misc-next 13/13] mei: virtio: virtualization frontend driver |
| |
On Thu, Dec 03, 2020 at 04:51:10PM -0500, Michael S. Tsirkin wrote: > On Wed, Nov 25, 2020 at 09:18:04PM +0000, Winkler, Tomas wrote: > > > > > > On Tue, Aug 18, 2020 at 02:51:47PM +0300, Tomas Winkler wrote: > > > > +#ifndef VIRTIO_ID_MEI > > > > +#define VIRTIO_ID_MEI 0xFFFE /* virtio mei */ #endif > > > > > > Just noticed now that this driver landed upstream. Can I ask that you guys > > > please register IDs with the virtio TC and not just pick a number at random? > > > In particular this is way outside allowed range. > > > > > > IDs should also be listed in include/uapi/linux/virtio_ids.h > > > > > > If people just pick random numbers like this collistions are unavoidable. > > > > > > List of IDs is part of virtio spec, chapter "Device Types". > > > > > > Please do this change now before this goes out to production! > > Okay, this was assigned by ACRN, my impression was it's already registered. > > Will take care of. > > Thanks > > Tomas > > Well nothing happened yet. > > I think at this point we really should revert this patch before Linux is > released so in the next version the correct ID can be used instead of a reserved one. > Otherwise Linux will be stuck supporting this forever and will conflict > with hypervisors using this for what this range is for which is > experimental use. > > Greg, any opinion on that?
I will be glad to revert it, what's the git commit id?
thanks,
greg k-h
| |