lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: udp: remove redundant initialization in udp_gro_complete
On Fri,  6 Nov 2020 01:42:39 -0500 menglong8.dong@gmail.com wrote:
> {
> __be16 newlen = htons(skb->len - nhoff);
> struct udphdr *uh = (struct udphdr *)(skb->data + nhoff);
> - int err = -ENOSYS;
> + int err;
> struct sock *sk;

You can also move the err declaration below struct sock *sk; to get
this closer to revert xmas tree order. In other patches it'd increase
change / potential conflict radius but here the correct position is
close enough so we can move.

\
 
 \ /
  Last update: 2020-11-09 19:29    [W:0.060 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site