Messages in this thread | | | Subject | Re: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables | From | Tomi Valkeinen <> | Date | Fri, 6 Nov 2020 16:03:11 +0200 |
| |
On 05/11/2020 20:07, Lee Jones wrote: > On Thu, 05 Nov 2020, Tomi Valkeinen wrote: > >> On 05/11/2020 16:45, Lee Jones wrote: >>> Fixes the following W=1 kernel build warning(s): >>> >>> drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’: >>> drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not used [-Wunused-but-set-variable] >>> drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’: >>> drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but not used [-Wunused-but-set-variable] >>> drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but not used [-Wunused-but-set-variable] >>> >>> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> >>> Cc: David Airlie <airlied@linux.ie> >>> Cc: Daniel Vetter <daniel@ffwll.ch> >>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> Cc: dri-devel@lists.freedesktop.org >>> Signed-off-by: Lee Jones <lee.jones@linaro.org> >>> --- >>> drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++------- >>> 1 file changed, 2 insertions(+), 7 deletions(-) >> >> I'd use "drm/omap: dsi: " subject prefix, the current one is fine too: >> >> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> >> >> Should I pick this up or do you want to keep the series intact? > > If you are in a position to take it, please do so. > > I rebase every day, so it will just vanish from my working set.
I have a 56 patch series on dsi.c that I sent yesterday, and it conflicts with this one. I'll pick this one on top of my series.
Tomi
-- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
| |