lkml.org 
[lkml]   [2020]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 07/20] input: keyboard: cros_ec_keyb: Struct headers should start with 'struct <name>'
    Hi Lee,

    On Wed, Nov 04, 2020 at 04:24:14PM +0000, Lee Jones wrote:
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/input/keyboard/cros_ec_keyb.c:72: warning: cannot understand function prototype: 'struct cros_ec_bs_map '
    >
    > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    > Cc: Benson Leung <bleung@chromium.org>
    > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
    > Cc: Guenter Roeck <groeck@chromium.org>
    > Cc: linux-input@vger.kernel.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Reviewed-by: Benson Leung <bleung@chromium.org>

    > ---
    > drivers/input/keyboard/cros_ec_keyb.c | 5 ++---
    > 1 file changed, 2 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
    > index 15d17c7170816..fce0c839e1430 100644
    > --- a/drivers/input/keyboard/cros_ec_keyb.c
    > +++ b/drivers/input/keyboard/cros_ec_keyb.c
    > @@ -58,10 +58,9 @@ struct cros_ec_keyb {
    > struct notifier_block notifier;
    > };
    >
    > -
    > /**
    > - * cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch bitmap
    > - * #defines
    > + * struct cros_ec_bs_map - Struct mapping Linux keycodes to EC button/switch
    > + * bitmap #defines
    > *
    > * @ev_type: The type of the input event to generate (e.g., EV_KEY).
    > * @code: A linux keycode
    > --
    > 2.25.1
    >

    --
    Benson Leung
    Staff Software Engineer
    Chrome OS Kernel
    Google Inc.
    bleung@google.com
    Chromium OS Project
    bleung@chromium.org
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2020-11-04 18:16    [W:2.539 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site