lkml.org 
[lkml]   [2020]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer()
    On Thu, Nov 26, 2020 at 07:11:42PM +0000, Lad Prabhakar wrote:
    > In the error path of rpcif_manual_xfer() the value of ret is overwritten
    > by value returned by reset_control_reset() function and thus returning
    > incorrect value to the caller.
    >
    > This patch makes sure the correct value is returned to the caller of
    > rpcif_manual_xfer() by dropping the overwrite of ret in error path.
    > Also now we ignore the value returned by reset_control_reset() in the
    > error path and instead print a error message when it fails.
    >
    > Fixes: ca7d8b980b67f ("memory: add Renesas RPC-IF driver")
    > Reported-by: Pavel Machek <pavel@denx.de>
    > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
    > Cc: stable@vger.kernel.org
    > Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
    > ---
    > drivers/memory/renesas-rpc-if.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)

    Thanks, applied to mem-ctrl tree.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2020-11-28 23:39    [W:6.234 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site