lkml.org 
[lkml]   [2020]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 03/15] remoteproc: Remove useless check in rproc_del()
    Date
    Whether started at probe() time or thereafter from the command
    line, a remote processor needs to be shutdown before the final
    cleanup phases can happen. Otherwise the system may be left in
    an unpredictable state where the remote processor is expecting
    the remoteproc core to be providing services when in fact it
    no longer exist.

    Invariably calling rproc_shutdown() is fine since it will return
    immediately if the remote processor has already been switched
    off.

    Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Reviewed-by: Peng Fan <peng.fan@nxp.com>
    Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
    ---
    drivers/remoteproc/remoteproc_core.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
    index e8b901f34c91..a2b9cd541315 100644
    --- a/drivers/remoteproc/remoteproc_core.c
    +++ b/drivers/remoteproc/remoteproc_core.c
    @@ -2346,10 +2346,8 @@ int rproc_del(struct rproc *rproc)
    if (!rproc)
    return -EINVAL;

    - /* if rproc is marked always-on, rproc_add() booted it */
    /* TODO: make sure this works with rproc->power > 1 */
    - if (rproc->auto_boot)
    - rproc_shutdown(rproc);
    + rproc_shutdown(rproc);

    mutex_lock(&rproc->lock);
    rproc->state = RPROC_DELETED;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-26 22:08    [W:2.093 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site