Messages in this thread | | | From | Robert Foss <> | Date | Thu, 26 Nov 2020 16:58:48 +0100 | Subject | Re: [PATCH v1] i2c: qcom: Fix IRQ error misassignement |
| |
Thanks for the review Mani.
On Thu, 26 Nov 2020 at 16:03, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > On Thu, Nov 26, 2020 at 03:53:21PM +0100, Robert Foss wrote: > > During cci_isr() errors read from register fields belonging to > > i2c master1 are currently assigned to the status field belonging to > > s/correctly/incorrectly
I don't think there actually is an error in the comment.
> > > i2c master0. This patch corrects this error, and always assigns > > master1 errors to the status field of master1. > > > > This patch fixes a legitimate bug. So there should be a fixes tag!
On it, fixed in v2
> > > Suggested-by: Loic Poulain <loic.poulain@linaro.org> > > Reported-by?
I'll add both in v2
| |