lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 34/47] powerpc/uaccess-flush: fix missing includes in kup-radix.h
    Date
    From: Daniel Axtens <dja@axtens.net>

    Guenter reports a build failure on cell_defconfig and maple_defconfg:

    In file included from arch/powerpc/include/asm/kup.h:10:0,
    from arch/powerpc/include/asm/uaccess.h:12,
    from arch/powerpc/lib/checksum_wrappers.c:24:
    arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: data definition has no type or storage class [-Werror]
    DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);
    ^~~~~~~~~~~~~~~~~~~~~~~~
    arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: type defaults to ‘int’ in declaration of ‘DECLARE_STATIC_KEY_FALSE’ [-Werror=implicit-int]
    arch/powerpc/include/asm/book3s/64/kup-radix.h:5:1: error: parameter names (without types) in function declaration [-Werror]
    arch/powerpc/include/asm/book3s/64/kup-radix.h: In function ‘prevent_user_access’:
    arch/powerpc/include/asm/book3s/64/kup-radix.h:18:6: error: implicit declaration of function ‘static_branch_unlikely’ [-Werror=implicit-function-declaration]
    if (static_branch_unlikely(&uaccess_flush_key))
    ^~~~~~~~~~~~~~~~~~~~~~
    arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: error: ‘uaccess_flush_key’ undeclared (first use in this function); did you mean
    ‘do_uaccess_flush’?
    if (static_branch_unlikely(&uaccess_flush_key))
    ^~~~~~~~~~~~~~~~~
    do_uaccess_flush
    arch/powerpc/include/asm/book3s/64/kup-radix.h:18:30: note: each undeclared identifier is reported only once for each function it appears in
    cc1: all warnings being treated as errors

    This is because I failed to include linux/jump_label.h in kup-radix.h. Include it.

    Reported-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Daniel Axtens <dja@axtens.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/powerpc/include/asm/book3s/64/kup-radix.h | 1 +
    1 file changed, 1 insertion(+)

    --- a/arch/powerpc/include/asm/book3s/64/kup-radix.h
    +++ b/arch/powerpc/include/asm/book3s/64/kup-radix.h
    @@ -1,6 +1,7 @@
    /* SPDX-License-Identifier: GPL-2.0 */
    #ifndef _ASM_POWERPC_BOOK3S_64_KUP_RADIX_H
    #define _ASM_POWERPC_BOOK3S_64_KUP_RADIX_H
    +#include <linux/jump_label.h>

    DECLARE_STATIC_KEY_FALSE(uaccess_flush_key);


    \
     
     \ /
      Last update: 2020-11-23 14:41    [W:4.021 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site