lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 131/252] can: dev: can_restart(): post buffer from the right context
    Date
    From: Alejandro Concepcion Rodriguez <alejandro@acoro.eu>

    [ Upstream commit a1e654070a60d5d4f7cce59c38f4ca790bb79121 ]

    netif_rx() is meant to be called from interrupt contexts. can_restart() may be
    called by can_restart_work(), which is called from a worqueue, so it may run in
    process context. Use netif_rx_ni() instead.

    Fixes: 39549eef3587 ("can: CAN Network device driver and Netlink interface")
    Co-developed-by: Loris Fauster <loris.fauster@ttcontrol.com>
    Signed-off-by: Loris Fauster <loris.fauster@ttcontrol.com>
    Signed-off-by: Alejandro Concepcion Rodriguez <alejandro@acoro.eu>
    Link: https://lore.kernel.org/r/4e84162b-fb31-3a73-fa9a-9438b4bd5234@acoro.eu
    [mkl: use netif_rx_ni() instead of netif_rx_any_context()]
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/can/dev.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
    index d5e52ffc7ed25..4bc9aa6c34787 100644
    --- a/drivers/net/can/dev.c
    +++ b/drivers/net/can/dev.c
    @@ -566,7 +566,7 @@ static void can_restart(struct net_device *dev)

    cf->can_id |= CAN_ERR_RESTARTED;

    - netif_rx(skb);
    + netif_rx_ni(skb);

    stats->rx_packets++;
    stats->rx_bytes += cf->can_dlc;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-23 14:41    [W:4.083 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site