lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] events/core: introduce perf_pmu_disable_all() to turn off all PMU
    On Mon, Nov 23, 2020 at 01:37:25PM +0800, Pingfan Liu wrote:

    > +/* When crashed, other cpus hang in idle loop, so here do an emergency job under no lock */

    -ENOPARSE, -ETOOLONG

    > +void perf_pmu_disable_all(void)
    > +{
    > + struct pmu *pmu;
    > +
    > + list_for_each_entry(pmu, &pmus, entry)
    > + if (pmu->pmu_disable)
    > + pmu->pmu_disable(pmu);
    > +}

    This violates both locking rules and coding style.

    \
     
     \ /
      Last update: 2020-11-23 15:17    [W:2.363 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site