lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 18/19] gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused
    On Thu, Nov 5, 2020 at 9:52 AM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > These 3 variables are used in *some* sourcefiles which include
    > amdgpu.h, but not *all*. This leads to a flurry of build warnings.
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > from drivers/gpu/drm/amd/amdgpu/amdgpu.h:67,
    > drivers/gpu/drm/amd/amdgpu/amdgpu.h:198:19: warning: ‘no_system_mem_limit’ defined but not used [-Wunused-const-variable=]
    > drivers/gpu/drm/amd/amdgpu/amdgpu.h:197:19: warning: ‘debug_evictions’ defined but not used [-Wunused-const-variable=]
    > drivers/gpu/drm/amd/amdgpu/amdgpu.h:196:18: warning: ‘sched_policy’ defined but not used [-Wunused-const-variable=]
    >
    > NB: Repeats ~650 times - snipped for brevity.
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: Sumit Semwal <sumit.semwal@linaro.org>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Cc: linux-media@vger.kernel.org
    > Cc: linaro-mm-sig@lists.linaro.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
    > index 183b09d71b64a..5939753080056 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
    > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
    > @@ -193,9 +193,9 @@ extern int sched_policy;
    > extern bool debug_evictions;
    > extern bool no_system_mem_limit;
    > #else
    > -static const int sched_policy = KFD_SCHED_POLICY_HWS;
    > -static const bool debug_evictions; /* = false */
    > -static const bool no_system_mem_limit;
    > +static const int __maybe_unused sched_policy = KFD_SCHED_POLICY_HWS;
    > +static const bool __maybe_unused debug_evictions; /* = false */
    > +static const bool __maybe_unused no_system_mem_limit;
    > #endif
    >
    > extern int amdgpu_tmz;
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-10 22:49    [W:3.980 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site