lkml.org 
[lkml]   [2020]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v1] ARM: vfp: Use long jump to fix THUMB2 kernel compilation error
    On Tue, 10 Nov 2020 at 08:44, Dmitry Osipenko <digetx@gmail.com> wrote:
    >
    > 09.11.2020 10:25, Ard Biesheuvel пишет:
    > ...
    > >>> So the options are
    > >>>
    > >>> a) merge my patch that adds 2 bytes of opcode to the Thumb2 build
    > >>> b) merge Dmitry's patch that adds an unconditional literal load to all builds
    > >>> c) remove kernel mode handling from vfp_support_entry() [my other patch]
    > >>> d) move sections around so that vfp_kmode_exception is guaranteed to
    > >>> be in range.
    > >>> e) do nothing
    > ...
    > >> The performance argument is questionable to me, to be honest. In
    > >> practice the performance difference should be absolutely negligible for
    > >> either of the proposed options, it should stay in a noise even if
    > >> somebody thoroughly counting cycles, IMO.
    > >>
    > >> I'm still thinking that the best option will be to apply a).
    > >>
    > >
    > > Can we take that as an acked-by?
    >
    > Are you asking me for the ack?

    Yes.

    > I think this is a more appropriate
    > question to Russel. I'm not arm/ maintainer, but could give r-b and t-b.
    >

    R-b and acked-by are basically the same thing.

    > If you're going to follow approach that I'm suggesting with a) + d),
    > then could you please resend the two patches in a single series? The
    > first one-line patch-fix should contain the fixes tag.

    Ok

    \
     
     \ /
      Last update: 2020-11-10 08:46    [W:7.122 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site