Messages in this thread | | | Subject | Re: [External] Re: [PATCH v3 04/21] mm/hugetlb: Introduce nr_free_vmemmap_pages in the struct hstate | From | Mike Kravetz <> | Date | Tue, 10 Nov 2020 11:38:36 -0800 |
| |
On 11/9/20 6:42 PM, Muchun Song wrote: > On Tue, Nov 10, 2020 at 12:48 AM Oscar Salvador <osalvador@suse.de> wrote: >> >> On Sun, Nov 08, 2020 at 10:10:56PM +0800, Muchun Song wrote: >> >> Unrelated to this patch but related in general, I am not sure about Mike but >> would it be cleaner to move all the vmemmap functions to hugetlb_vmemmap.c? >> hugetlb code is quite tricky, so I am not sure about stuffing more code >> in there. >> > > I also think that you are right, moving all the vmemmap functions to > hugetlb_vmemmap.c may make the code cleaner. > > Hi Mike, what's your opinion?
I would be happy to see this in a separate file. As Oscar mentions, the hugetlb.c file/code is already somethat difficult to read and understand. -- Mike Kravetz
| |