Messages in this thread | | | From | Jakub Sitnicki <> | Subject | Re: [PATCH] net: sockmap: Don't call bpf_prog_put() on NULL pointer | Date | Wed, 14 Oct 2020 11:20:39 +0200 |
| |
On Mon, Oct 12, 2020 at 07:09 PM CEST, Alex Dewar wrote: > If bpf_prog_inc_not_zero() fails for skb_parser, then bpf_prog_put() is > called unconditionally on skb_verdict, even though it may be NULL. Fix > and tidy up error path. > > Addresses-Coverity-ID: 1497799: Null pointer dereferences (FORWARD_NULL) > Fixes: 743df8b7749f ("bpf, sockmap: Check skb_verdict and skb_parser programs explicitly") > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com> > ---
Acked-by: Jakub Sitnicki <jakub@cloudflare.com>
| |