Messages in this thread | | | Date | Wed, 14 Oct 2020 11:52:51 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET |
| |
On Wed, Oct 14, 2020 at 03:39:51PM +0800, kernel test robot wrote: > Hi Michael, > > Thank you for the patch! Yet something to improve:
Wondering if you compile this at all...
> include/asm-generic/io.h:1017:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] > return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port; > ~~~~~~~~~~ ^ > >> drivers/i2c/busses/i2c-designware-slave.c:181:42: error: expected ';' after expression > dev->status = STATUS_WRITE_IN_PROGRESS > ^ > ; > >> drivers/i2c/busses/i2c-designware-slave.c:195:22: error: use of undeclared identifier 'STATUS_IDEL' > if (dev->status != STATUS_IDEL) { > ^ > 7 warnings and 2 errors generated.
-- With Best Regards, Andy Shevchenko
| |