lkml.org 
[lkml]   [2020]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH RFC PKS/PMEM 33/58] fs/cramfs: Utilize new kmap_thread()
    On Fri, Oct 9, 2020 at 12:52 PM <ira.weiny@intel.com> wrote:
    >
    > From: Ira Weiny <ira.weiny@intel.com>
    >
    > The kmap() calls in this FS are localized to a single thread. To avoid
    > the over head of global PKRS updates use the new kmap_thread() call.
    >
    > Cc: Nicolas Pitre <nico@fluxnic.net>
    > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
    > ---
    > fs/cramfs/inode.c | 10 +++++-----
    > 1 file changed, 5 insertions(+), 5 deletions(-)
    >
    > diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c
    > index 912308600d39..003c014a42ed 100644
    > --- a/fs/cramfs/inode.c
    > +++ b/fs/cramfs/inode.c
    > @@ -247,8 +247,8 @@ static void *cramfs_blkdev_read(struct super_block *sb, unsigned int offset,
    > struct page *page = pages[i];
    >
    > if (page) {
    > - memcpy(data, kmap(page), PAGE_SIZE);
    > - kunmap(page);
    > + memcpy(data, kmap_thread(page), PAGE_SIZE);
    > + kunmap_thread(page);

    Why does this need a sleepable kmap? This looks like a textbook
    kmap_atomic() use case.

    \
     
     \ /
      Last update: 2020-10-13 20:46    [W:4.795 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site