lkml.org 
[lkml]   [2020]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] dt-bindings: leds: choose correct color value of multi-led
Hi!

> > --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> > +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> > @@ -197,7 +197,7 @@ examples:
> > #address-cells = <1>;
> > #size-cells = <0>;
> > reg = <0x2>;
> > - color = <LED_COLOR_ID_RGB>;
> > + color = <LED_COLOR_ID_MULTI>;
> > function = LED_FUNCTION_STANDBY;
> > linux,default-trigger = "heartbeat";
>
> This is not correct.  ID_RGB is the correct variable here.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=3d93edc77515c6f51fa9bbbe2185e2ec32bad024
>
> Correct fix is to update the leds-class-multicolor.yaml

Right. So lets not merge this one.

Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2020-10-13 19:05    [W:0.088 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site