lkml.org 
[lkml]   [2020]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 034/124] xfrmi: drop ignore_df check before updating pmtu
    Date
    From: Sabrina Dubroca <sd@queasysnail.net>

    commit 45a36a18d01907710bad5258d81f76c18882ad88 upstream.

    xfrm interfaces currently test for !skb->ignore_df when deciding
    whether to update the pmtu on the skb's dst. Because of this, no pmtu
    exception is created when we do something like:

    ping -s 1438 <dest>

    By dropping this check, the pmtu exception will be created and the
    next ping attempt will work.

    Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces")
    Reported-by: Xiumei Mu <xmu@redhat.com>
    Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
    Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/xfrm/xfrm_interface.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/xfrm/xfrm_interface.c
    +++ b/net/xfrm/xfrm_interface.c
    @@ -292,7 +292,7 @@ xfrmi_xmit2(struct sk_buff *skb, struct
    }

    mtu = dst_mtu(dst);
    - if (!skb->ignore_df && skb->len > mtu) {
    + if (skb->len > mtu) {
    skb_dst_update_pmtu_no_confirm(skb, mtu);

    if (skb->protocol == htons(ETH_P_IPV6)) {

    \
     
     \ /
      Last update: 2020-10-12 15:46    [W:4.095 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site