lkml.org 
[lkml]   [2020]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] dynamic_debug: allow to work if debugfs is disabled
    On Wed, Jan 22, 2020 at 08:31:18PM +0100, Greg Kroah-Hartman wrote:
    > With the realization that having debugfs enabled on "production" systems is
    > generally not a good idea, debugfs is being disabled from more and more
    > platforms over time. However, the functionality of dynamic debugging still is
    > needed at times, and since it relies on debugfs for its user api, having
    > debugfs disabled also forces dynamic debug to be disabled.
    >
    > To get around this, move the "control" file for dynamic_debug to procfs IFF
    > debugfs is disabled. This lets people turn on debugging as needed at runtime
    > for individual driverfs and subsystems.

    Instead of moving the control file IFF debugfs is enabled, what about
    always making it available in /proc, and marking the control file for
    dynamic_debug in debugfs as deprecated? It would seem to me that this
    would cause less confusion in the future....

    - Ted

    \
     
     \ /
      Last update: 2020-01-23 16:55    [W:3.008 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site