Messages in this thread | | | From | Sergey Senozhatsky <> | Date | Tue, 10 Sep 2019 01:05:39 +0900 | Subject | Re: [PATCH v2 7/7] bug: Move WARN_ON() "cut here" into exception handler |
| |
On (08/20/19 09:47), Kees Cook wrote: [..] > @@ -181,6 +181,15 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs) > } > } > > + /* > + * BUG() and WARN_ON() families don't print a custom debug message > + * before triggering the exception handler, so we must add the > + * "cut here" line now. WARN() issues its own "cut here" before the > + * extra debugging message it writes before triggering the handler. > + */ > + if ((bug->flags & BUGFLAG_NO_CUT_HERE) == 0) > + printk(KERN_DEFAULT CUT_HERE);
Shouldn't this be pr_warn() or pr_crit()?
-ss
| |