| From | Matthew Garrett <> | Date | Wed, 4 Sep 2019 09:51:16 -0700 | Subject | Re: [PATCH V40 03/29] security: Add a static lockdown policy LSM |
| |
On Fri, Aug 30, 2019 at 9:28 AM David Howells <dhowells@redhat.com> wrote: > > Matthew Garrett <matthewgarrett@google.com> wrote: > > > +static char *lockdown_reasons[LOCKDOWN_CONFIDENTIALITY_MAX+1] = { > > const char *const maybe?
Seems reasonable.
> > +static enum lockdown_reason lockdown_levels[] = {LOCKDOWN_NONE, > > + LOCKDOWN_INTEGRITY_MAX, > > + LOCKDOWN_CONFIDENTIALITY_MAX}; > > + > > const? > > Isn't this also a 1:1 mapping?
Sorry, a 1:1 mapping to what?
> > +static int lock_kernel_down(const char *where, enum lockdown_reason level) > > Is the last parameter the reason or the level? You're mixing the terms.
Fair.
|