Messages in this thread | | | Subject | Re: [PATCH v2] drm/amdgpu: fix multiple memory leaks | From | Markus Elfring <> | Date | Fri, 27 Sep 2019 18:37:37 +0200 |
| |
> v2: moved the released into goto error handlings
A better version comment should be moved below the triple dashes.
Will the tag “Fixes” be added?
> @@ -393,6 +395,16 @@ static int acp_hw_init(void *handle) > val &= ~ACP_SOFT_RESET__SoftResetAud_MASK; > cgs_write_register(adev->acp.cgs_device, mmACP_SOFT_RESET, val); > return 0; > + > +out4: > + kfree(i2s_pdata); > +out3: > + kfree(adev->acp.acp_res); > +out2: > + kfree(adev->acp.acp_cell); > +out1: > + kfree(adev->acp.acp_genpd); > + return ret; > } > > /**
I suggest to reconsider the label selection according to the Linux coding style.
Regards, Markus
| |