Messages in this thread | | | Subject | Re: [PATCH v2 3/3] platform/x86: intel_oaktrail: Use pr_warn instead of pr_warning | From | Kefeng Wang <> | Date | Thu, 26 Sep 2019 15:48:51 +0800 |
| |
On 2019/9/26 15:32, Andy Shevchenko wrote: > On Thu, Sep 26, 2019 at 9:09 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: >> On 2019/9/26 13:48, Andy Shevchenko wrote: >>> On Thu, Sep 26, 2019 at 4:29 AM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: >>>> On 2019/9/25 23:04, Andy Shevchenko wrote: >>>>> On Fri, Sep 20, 2019 at 1:55 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote: >>>>> You have to send to proper mailing lists and people. >>>> Used get_maintainer.pl to find the people, and all already in the CC, will add proper maillist into each patch. >>>> >>>>> Don't spam the rest! >>>> Not so clearly, should I not CC other people not in the list below? >>>> >>>> [wkf@localhost linux]$ ./scripts/get_maintainer.pl pr_warning/v3/0018-platform-x86-eeepc-laptop-Use-pr_warn-instead-of-pr_.patch >>>> Corentin Chary <corentin.chary@gmail.com> (maintainer:ASUS NOTEBOOKS AND EEEPC ACPI/WMI EXTRAS DRIVERS) >>>> Darren Hart <dvhart@infradead.org> (odd fixer:X86 PLATFORM DRIVERS) >>>> Andy Shevchenko <andy@infradead.org> (odd fixer:X86 PLATFORM DRIVERS) >>> You put a lot more people in Cc, than above list contains. >> >> This is a treewide change, and finally kill pr_warning in the whole linux code, so I add more people into Cc list. > > No _this_ is change for only one subsystem / driver. > Since the set is of independent patches, you may add all people to > cover letter which I happened not to see and to the patches that are > core of the series (like one with pr_warning() kill). > > For now I considered them as completely independent to push thru my tree. > In any case you have to carefully choose the Cc list per each patch in > a treewide changes. > >> Here is a brief discussion about how this be picked up, is this ok for you? >> >> https://lore.kernel.org/lkml/82fe3d04-2985-7844-31bb-269655c83873@huawei.com/ > > I haven't got this. Care to do what I said above about cover letter > and tell all stakeholders what you are expecting from them to do.
Got it, will put all stakeholders into cover letter next time. Thanks for your patient guidance. >
| |