Messages in this thread Patch in this message | | | From | Rui Miguel Silva <> | Subject | Re: [PATCH] staging: media: imx: Use devm_platform_ioremap_resource(). | Date | Thu, 26 Sep 2019 18:24:59 +0100 |
| |
Hi Jeeeun, On Thu 26 Sep 2019 at 16:55, Jeeeun Evans wrote: > This patch fixes a warning by coccicheck: > drivers/staging/media/imx/imx7-mipi-csis.c:973:1-12: WARNING: Use devm_platform_ioremap_resource for state -> regs > > Use devm_platform_ioremap_resource helper which wraps platform_get_resource() > and devm_ioremap_resource() together. > > Signed-off-by: Jeeeun Evans <jeeeunevans@gmail.com> >
Thanks for the patch. LGTM.
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
--- Cheers, Rui
> drivers/staging/media/imx/imx7-mipi-csis.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > index 73d8354e618c..bf21db38441f 100644 > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > @@ -947,7 +947,6 @@ static void mipi_csis_debugfs_exit(struct csi_state *state) > static int mipi_csis_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct resource *mem_res; > struct csi_state *state; > int ret; > > @@ -969,8 +968,7 @@ static int mipi_csis_probe(struct platform_device *pdev) > mipi_csis_phy_init(state); > mipi_csis_phy_reset(state); > > - mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - state->regs = devm_ioremap_resource(dev, mem_res); > + state->regs = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(state->regs)) > return PTR_ERR(state->regs);
| |