lkml.org 
[lkml]   [2019]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.2 38/56] tun: mark small packets as owned by the tap sock
    Date
    From: Alexis Bauvin <abauvin@scaleway.com>

    [ Upstream commit 4b663366246be1d1d4b1b8b01245b2e88ad9e706 ]

    - v1 -> v2: Move skb_set_owner_w to __tun_build_skb to reduce patch size

    Small packets going out of a tap device go through an optimized code
    path that uses build_skb() rather than sock_alloc_send_pskb(). The
    latter calls skb_set_owner_w(), but the small packet code path does not.

    The net effect is that small packets are not owned by the userland
    application's socket (e.g. QEMU), while large packets are.
    This can be seen with a TCP session, where packets are not owned when
    the window size is small enough (around PAGE_SIZE), while they are once
    the window grows (note that this requires the host to support virtio
    tso for the guest to offload segmentation).
    All this leads to inconsistent behaviour in the kernel, especially on
    netfilter modules that uses sk->socket (e.g. xt_owner).

    Fixes: 66ccbc9c87c2 ("tap: use build_skb() for small packet")
    Signed-off-by: Alexis Bauvin <abauvin@scaleway.com>
    Acked-by: Jason Wang <jasowang@redhat.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/tun.c | 9 ++++++---
    1 file changed, 6 insertions(+), 3 deletions(-)

    --- a/drivers/net/tun.c
    +++ b/drivers/net/tun.c
    @@ -1600,7 +1600,8 @@ static bool tun_can_build_skb(struct tun
    return true;
    }

    -static struct sk_buff *__tun_build_skb(struct page_frag *alloc_frag, char *buf,
    +static struct sk_buff *__tun_build_skb(struct tun_file *tfile,
    + struct page_frag *alloc_frag, char *buf,
    int buflen, int len, int pad)
    {
    struct sk_buff *skb = build_skb(buf, buflen);
    @@ -1610,6 +1611,7 @@ static struct sk_buff *__tun_build_skb(s

    skb_reserve(skb, pad);
    skb_put(skb, len);
    + skb_set_owner_w(skb, tfile->socket.sk);

    get_page(alloc_frag->page);
    alloc_frag->offset += buflen;
    @@ -1687,7 +1689,8 @@ static struct sk_buff *tun_build_skb(str
    */
    if (hdr->gso_type || !xdp_prog) {
    *skb_xdp = 1;
    - return __tun_build_skb(alloc_frag, buf, buflen, len, pad);
    + return __tun_build_skb(tfile, alloc_frag, buf, buflen, len,
    + pad);
    }

    *skb_xdp = 0;
    @@ -1724,7 +1727,7 @@ static struct sk_buff *tun_build_skb(str
    rcu_read_unlock();
    local_bh_enable();

    - return __tun_build_skb(alloc_frag, buf, buflen, len, pad);
    + return __tun_build_skb(tfile, alloc_frag, buf, buflen, len, pad);

    err_xdp:
    put_page(alloc_frag->page);

    \
     
     \ /
      Last update: 2019-08-08 21:15    [W:4.047 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site