lkml.org 
[lkml]   [2019]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 1/5] dt-bindings: clock: Add Bitmain BM1880 SoC clock controller binding
    Date
    Quoting Manivannan Sadhasivam (2019-07-05 08:14:36)
    > Add devicetree binding for Bitmain BM1880 SoC clock controller.
    >
    > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    > ---
    > .../bindings/clock/bitmain,bm1880-clk.txt | 47 +++++++++++

    Can you convert this to YAML? It's all the rage right now.

    > include/dt-bindings/clock/bm1880-clock.h | 82 +++++++++++++++++++
    > 2 files changed, 129 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.txt
    > create mode 100644 include/dt-bindings/clock/bm1880-clock.h
    >
    > diff --git a/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.txt b/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.txt
    > new file mode 100644
    > index 000000000000..9c967095d430
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/clock/bitmain,bm1880-clk.txt
    > @@ -0,0 +1,47 @@
    > +* Bitmain BM1880 Clock Controller
    > +
    > +The Bitmain BM1880 clock controler generates and supplies clock to
    > +various peripherals within the SoC.
    > +
    > +Required Properties:
    > +
    > +- compatible: Should be "bitmain,bm1880-clk"
    > +- reg : Register address and size of PLL and SYS control domains
    > +- reg-names : Register domain names: "pll" and "sys"
    > +- clocks : Phandle of the input reference clock.
    > +- #clock-cells: Should be 1.
    > +
    > +Each clock is assigned an identifier, and client nodes can use this identifier
    > +to specify the clock which they consume.
    > +
    > +All available clocks are defined as preprocessor macros in corresponding
    > +dt-bindings/clock/bm1880-clock.h header and can be used in device tree sources.
    > +
    > +External clocks:
    > +
    > +The osc clock used as the input for the plls is generated outside the SoC.
    > +It is expected that it is defined using standard clock bindings as "osc".
    > +
    > +Example:
    > +
    > + clk: clock-controller@800 {
    > + compatible = "bitmain,bm1880-clk";
    > + reg = <0xe8 0x0c>,<0x800 0xb0>;

    It looks weird still. What hardware module is this actually part of?
    Some larger power manager block?

    > + reg-names = "pll", "sys";
    > + clocks = <&osc>;
    > + #clock-cells = <1>;
    > + };
    > +

    \
     
     \ /
      Last update: 2019-08-08 07:02    [W:8.128 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site