Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Fix non-kerneldoc comment in realtek/rtlwifi/usb.c | From | Larry Finger <> | Date | Wed, 7 Aug 2019 19:57:52 -0500 |
| |
On 8/7/19 5:39 PM, Valdis Klētnieks wrote:
When this driver was originally entered, a line with "/*" was flagged by checkpatch.pl. In fact, when I make your change, I get
WARNING: networking block comments don't use an empty /* line, use /* Comment... #243: FILE: drivers/net/wireless/realtek/rtlwifi/usb.c:243: +/* + *
To avoid a loop of "fixing" compiler/checkpatch warnings, you need to put the first real line of the comment on the line of the "/*". For the first of your patches, that results in
diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c index 34d68dbf4b4c..f89ceac25eff 100644 --- a/drivers/net/wireless/realtek/rtlwifi/usb.c +++ b/drivers/net/wireless/realtek/rtlwifi/usb.c @@ -239,10 +239,7 @@ static void _rtl_usb_io_handler_release(struct ieee80211_hw *hw) mutex_destroy(&rtlpriv->io.bb_mutex); } -/** - * - * Default aggregation handler. Do nothing and just return the oldest skb. - */ +/* Default aggregation handler. Do nothing and just return the oldest skb. */ static struct sk_buff *_none_usb_tx_aggregate_hdl(struct ieee80211_hw *hw, struct sk_buff_head *list)
Because you merely shift the warning to a different tool,
NACK. Larry
| |