Messages in this thread | | | Date | Wed, 7 Aug 2019 18:08:56 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v3 1/2] fork: extend clone3() to support CLONE_SET_TID |
| |
On 08/06, Adrian Reber wrote: > > @@ -2573,6 +2575,14 @@ noinline static int copy_clone_args_from_user(struct kernel_clone_args *kargs, > .tls = args.tls, > }; > > + if (size == sizeof(struct clone_args)) { > + /* Only check permissions if set_tid is actually set. */ > + if (args.set_tid && > + !ns_capable(pid_ns->user_ns, CAP_SYS_ADMIN))
and I just noticed this uses pid_ns = task_active_pid_ns() ...
is it correct?
I feel I am totally confused, but should we use the same p->nsproxy->pid_ns_for_children passed to alloc_pid?
Oleg.
| |