Messages in this thread | | | Date | Wed, 7 Aug 2019 13:09:59 +0200 | From | Greg KH <> | Subject | Re: [PATCH v8 1/3] PM / wakeup: Drop wakeup_source_init(), wakeup_source_prepare() |
| |
On Tue, Aug 06, 2019 at 06:48:44PM -0700, Tri Vo wrote: > wakeup_source_init() has no users. Remove it. > > As a result, wakeup_source_prepare() is only called from > wakeup_source_create(). Merge wakeup_source_prepare() into > wakeup_source_create() and remove it. > > Change wakeup_source_create() behavior so that assigning NULL to wakeup > source's name throws an error.
The kernel C code can not "throw" errors :)
Anyway, odd verbage asside, patch looks good to me:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |