lkml.org 
[lkml]   [2019]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ALSA: usb-midi: fix a memory leak bug
On Wed, 07 Aug 2019 05:22:09 +0200,
Wenwen Wang wrote:
>
> In __snd_usbmidi_create(), a MIDI streaming interface structure is
> allocated through kzalloc() and the pointer is saved to 'umidi'. Later on,
> the endpoint structures are created by invoking
> snd_usbmidi_create_endpoints_midiman() or snd_usbmidi_create_endpoints(),
> depending on the type of the audio quirk type. However, if the creation
> fails, the allocated 'umidi' is not deallocated, leading to a memory leak
> bug.
>
> To fix the above issue, free 'umidi' before returning the error.
>
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>

It's again a false-positive report. The object is released
automatically by the destructor of its base snd_rawmidi object.


thanks,

Takashi

\
 
 \ /
  Last update: 2019-08-07 07:33    [W:0.030 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site