lkml.org 
[lkml]   [2019]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V4 8/9] vhost: correctly set dirty pages in MMU notifiers callback
    Date
    We need make sure there's no reference on the map before trying to
    mark set dirty pages.

    Reported-by: Michael S. Tsirkin <mst@redhat.com>
    Fixes: 7f466032dc9e ("vhost: access vq metadata through kernel virtual address")
    Signed-off-by: Jason Wang <jasowang@redhat.com>
    ---
    drivers/vhost/vhost.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
    index 57bfbb60d960..6650a3ff88c1 100644
    --- a/drivers/vhost/vhost.c
    +++ b/drivers/vhost/vhost.c
    @@ -410,14 +410,13 @@ static void vhost_invalidate_vq_start(struct vhost_virtqueue *vq,
    ++vq->invalidate_count;

    map = vq->maps[index];
    - if (map) {
    - vhost_set_map_dirty(vq, map, index);
    + if (map)
    vq->maps[index] = NULL;
    - }
    spin_unlock(&vq->mmu_lock);

    if (map) {
    vhost_vq_sync_access(vq);
    + vhost_set_map_dirty(vq, map, index);
    vhost_map_unprefetch(map);
    }
    }
    --
    2.18.1
    \
     
     \ /
      Last update: 2019-08-07 09:08    [W:4.335 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site