Messages in this thread | | | Subject | Re: [PATCH v5 02/10] powerpc: move memstart_addr and kernstart_addr to init-common.c | From | Jason Yan <> | Date | Thu, 8 Aug 2019 11:32:03 +0800 |
| |
On 2019/8/7 21:02, Michael Ellerman wrote: > Jason Yan <yanaijie@huawei.com> writes: >> These two variables are both defined in init_32.c and init_64.c. Move >> them to init-common.c. >> >> Signed-off-by: Jason Yan <yanaijie@huawei.com> >> Cc: Diana Craciun <diana.craciun@nxp.com> >> Cc: Michael Ellerman <mpe@ellerman.id.au> >> Cc: Christophe Leroy <christophe.leroy@c-s.fr> >> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> >> Cc: Paul Mackerras <paulus@samba.org> >> Cc: Nicholas Piggin <npiggin@gmail.com> >> Cc: Kees Cook <keescook@chromium.org> >> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr> >> Reviewed-by: Diana Craciun <diana.craciun@nxp.com> >> Tested-by: Diana Craciun <diana.craciun@nxp.com> >> --- >> arch/powerpc/mm/init-common.c | 5 +++++ >> arch/powerpc/mm/init_32.c | 5 ----- >> arch/powerpc/mm/init_64.c | 5 ----- >> 3 files changed, 5 insertions(+), 10 deletions(-) >> >> diff --git a/arch/powerpc/mm/init-common.c b/arch/powerpc/mm/init-common.c >> index a84da92920f7..152ae0d21435 100644 >> --- a/arch/powerpc/mm/init-common.c >> +++ b/arch/powerpc/mm/init-common.c >> @@ -21,6 +21,11 @@ >> #include <asm/pgtable.h> >> #include <asm/kup.h> >> >> +phys_addr_t memstart_addr = (phys_addr_t)~0ull; >> +EXPORT_SYMBOL_GPL(memstart_addr); >> +phys_addr_t kernstart_addr; >> +EXPORT_SYMBOL_GPL(kernstart_addr); > > Would be nice if these can be __ro_after_init ? >
Good idea.
> cheers > > . >
| |