Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 6 Aug 2019 14:45:17 +0200 | Subject | Re: [PATCH] gpio: Fix build error of function redefinition |
| |
On Wed, Jul 31, 2019 at 2:39 PM YueHaibing <yuehaibing@huawei.com> wrote:
> when do randbuilding, I got this error: > > In file included from drivers/hwmon/pmbus/ucd9000.c:19:0: > ./include/linux/gpio/driver.h:576:1: error: redefinition of gpiochip_add_pin_range > gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, > ^~~~~~~~~~~~~~~~~~~~~~ > In file included from drivers/hwmon/pmbus/ucd9000.c:18:0: > ./include/linux/gpio.h:245:1: note: previous definition of gpiochip_add_pin_range was here > gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, > ^~~~~~~~~~~~~~~~~~~~~~ > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 964cb341882f ("gpio: move pincontrol calls to <linux/gpio/driver.h>") > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Yeah those get covered twice these days I suppose.
Patch applied, good catch.
Yours, Linus Walleij
| |