Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 7 Aug 2019 01:42:12 +0300 | From | Ivan Khoronzhuk <> | Subject | Re: [PATCH] net: sched: sch_taprio: fix memleak in error path for sched list parse |
| |
On Tue, Aug 06, 2019 at 11:41:14AM -0700, David Miller wrote: >From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> >Date: Tue, 6 Aug 2019 13:04:25 +0300 > >> Based on net/master > >I wonder about that because: Applies cleanly on net/master, but line num is not correct. I've sent v2.
> >> --- a/net/sched/sch_taprio.c >> +++ b/net/sched/sch_taprio.c >> @@ -1451,7 +1451,8 @@ static int taprio_change(struct Qdisc *sch, struct nlattr *opt, >> spin_unlock_bh(qdisc_lock(sch)); >> >> free_sched: >> - kfree(new_admin); >> + if (new_admin) >> + call_rcu(&new_admin->rcu, taprio_free_sched_cb); >> >> return err; > >In my tree the context around line 1451 is: > > nla_nest_end(skb, sched_nest); > >done: > rcu_read_unlock(); > > return nla_nest_end(skb, nest); > > >which is part of function taprio_dump(). > >Please respin this properly against current 'net' sources.
-- Regards, Ivan Khoronzhuk
| ![\](/images/icornerr.gif) |