Messages in this thread | | | From | <> | Subject | Re: [PATCH 2/5] mtd: spi-nor: group the code about the write protection at power-up | Date | Mon, 5 Aug 2019 06:30:02 +0000 |
| |
On 08/05/2019 08:44 AM, Vignesh Raghavendra wrote: >> From: Tudor Ambarus <tudor.ambarus@microchip.com> >> >> The write protection at power-up logic was split across functions >> because of a dependency to spansion_quad_enable(). Group the code >> in spi_nor_init() as the pointer to spansion_quad_enable() can be >> retrieved from nor->quad_enable. >> >> While touching this code, rename nor->clear_sr_bp() to >> nor->disable_write_protection() to better indicate its scope: it >> disables the default write protection after a power-on reset cycle. > I prefer this function to be renamed to nor->disable_block_protection() > so as to avoid being confused with write protect signal input to the flash.
You're right, I'll rename it.
Thanks, ta
| |