lkml.org 
[lkml]   [2019]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 40/74] x86, boot: Remove multiple copy of static function sanitize_boot_params()
    Date
    [ Upstream commit 8c5477e8046ca139bac250386c08453da37ec1ae ]

    Kernel build warns:
    'sanitize_boot_params' defined but not used [-Wunused-function]

    at below files:
    arch/x86/boot/compressed/cmdline.c
    arch/x86/boot/compressed/error.c
    arch/x86/boot/compressed/early_serial_console.c
    arch/x86/boot/compressed/acpi.c

    That's becausethey each include misc.h which includes a definition of
    sanitize_boot_params() via bootparam_utils.h.

    Remove the inclusion from misc.h and have the c file including
    bootparam_utils.h directly.

    Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Link: https://lkml.kernel.org/r/1563283092-1189-1-git-send-email-zhenzhong.duan@oracle.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/x86/boot/compressed/misc.c | 1 +
    arch/x86/boot/compressed/misc.h | 1 -
    2 files changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/boot/compressed/misc.c b/arch/x86/boot/compressed/misc.c
    index 8dd1d5ccae580..0387d7a96c842 100644
    --- a/arch/x86/boot/compressed/misc.c
    +++ b/arch/x86/boot/compressed/misc.c
    @@ -17,6 +17,7 @@
    #include "pgtable.h"
    #include "../string.h"
    #include "../voffset.h"
    +#include <asm/bootparam_utils.h>

    /*
    * WARNING!!
    diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed/misc.h
    index a423bdb426862..47fd18db6b3bf 100644
    --- a/arch/x86/boot/compressed/misc.h
    +++ b/arch/x86/boot/compressed/misc.h
    @@ -22,7 +22,6 @@
    #include <asm/page.h>
    #include <asm/boot.h>
    #include <asm/bootparam.h>
    -#include <asm/bootparam_utils.h>

    #define BOOT_BOOT_H
    #include "../ctype.h"
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-08-05 15:26    [W:2.798 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site