lkml.org 
[lkml]   [2019]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [Intel-wired-lan] [PATCH 2/2] ixgbe: Use refcount_t for refcount
    On Mon, Aug 5, 2019 at 5:43 PM Bowers, AndrewX <andrewx.bowers@intel.com> wrote:
    >
    > > -----Original Message-----
    > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On
    > > Behalf Of Chuhong Yuan
    > > Sent: Friday, August 2, 2019 3:55 AM
    > > Cc: netdev@vger.kernel.org; Chuhong Yuan <hslester96@gmail.com>; linux-
    > > kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; David S . Miller
    > > <davem@davemloft.net>
    > > Subject: [Intel-wired-lan] [PATCH 2/2] ixgbe: Use refcount_t for refcount
    > >
    > > refcount_t is better for reference counters since its implementation can
    > > prevent overflows.
    > > So convert atomic_t ref counters to refcount_t.
    > >
    > > Also convert refcount from 0-based to 1-based.
    > >
    > > This patch depends on PATCH 1/2.
    > >
    > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
    > > ---
    > > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.c | 6 +++---
    > > drivers/net/ethernet/intel/ixgbe/ixgbe_fcoe.h | 2 +-
    > > 2 files changed, 4 insertions(+), 4 deletions(-)
    >
    > Tested-by: Andrew Bowers <andrewx.bowers@intel.com>

    To reiterate, this patchset should not be applied as is. It is not
    correct to simply change the initial refcount.

    \
     
     \ /
      Last update: 2019-08-06 00:03    [W:5.059 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site