Messages in this thread | | | Date | Sun, 4 Aug 2019 18:22:15 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v3] net: phy: broadcom: add 1000Base-X support for BCM54616S |
| |
> > Even if that were the case (patching phy_attach_direct to apply a > > logical-or to dev_flags), it sounds fishy to me that the genphy code > > is unable to determine that this PHY is running in 1000Base-X mode. > > > > In my opinion it all boils down to this warning: > > > > "PHY advertising (0,00000200,000062c0) more modes than genphy > > supports, some modes not advertised". > > > The genphy code deals with Clause 22 + Gigabit BaseT only. > Question is whether you want aneg at all in 1000Base-X mode and > what you want the config_aneg callback to do. > There may be some inspiration in the Marvel PHY drivers.
As far as i know, you cannot actually advertise 1000Base-X. So we probably should not be setting the bit in advertise, only having it in supported?
Andrew
| |