Messages in this thread | | | Date | Sun, 4 Aug 2019 16:51:52 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v3] net: phy: broadcom: add 1000Base-X support for BCM54616S |
| |
> > The patchset looks better now. But is it ok, I wonder, to keep > > PHY_BCM_FLAGS_MODE_1000BX in phydev->dev_flags, considering that > > phy_attach_direct is overwriting it? >
> I checked ftgmac100 driver (used on my machine) and it calls > phy_connect_direct which passes phydev->dev_flags when calling > phy_attach_direct: that explains why the flag is not cleared in my > case.
Yes, that is the way it is intended to be used. The MAC driver can pass flags to the PHY. It is a fragile API, since the MAC needs to know what PHY is being used, since the flags are driver specific.
One option would be to modify the assignment in phy_attach_direct() to OR in the flags passed to it with flags which are already in phydev->dev_flags.
Andrew
| |