Messages in this thread | | | Subject | Re: [PATCH] r8188eu: use skb_put_data instead of skb_put/memcpy pair | From | Ivan Safonov <> | Date | Sat, 31 Aug 2019 20:30:16 +0300 |
| |
On 8/27/19 1:31 PM, Dan Carpenter wrote: > On Sun, Aug 25, 2019 at 11:48:58PM +0300, Ivan Safonov wrote: >> skb_put_data is shorter and clear. >> > > Please don't start the commit message in the middle of a sentence. It > often gets split from the start of the sentence. See how it looks here. > https://marc.info/?l=linux-driver-devel&m=156676594611401&w=2 > > >> Signed-off-by: Ivan Safonov <insafonov@gmail.com> >> --- >> drivers/staging/rtl8188eu/core/rtw_recv.c | 6 +----- >> drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 3 +-- >> 2 files changed, 2 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c >> b/drivers/staging/rtl8188eu/core/rtw_recv.c >> index 620da6c003d8..d4278361e002 100644 >> --- a/drivers/staging/rtl8188eu/core/rtw_recv.c >> +++ b/drivers/staging/rtl8188eu/core/rtw_recv.c >> @@ -1373,11 +1373,7 @@ static struct recv_frame *recvframe_defrag(struct >> adapter *adapter, >> /* append to first fragment frame's tail (if privacy frame, >> pull the ICV) */ >> skb_trim(prframe->pkt, prframe->pkt->len - >> prframe->attrib.icv_len); > > > Your email client corrupted the patch so it can't be applied.
Thanks, Dan. > > regards, > dan carpenter >
| |