lkml.org 
[lkml]   [2019]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH netdev] net: stmmac: dwmac-rk: Don't fail if phy regulator is absent
    From
    From: Chen-Yu Tsai <wens@kernel.org>
    Date: Thu, 29 Aug 2019 11:17:24 +0800

    > From: Chen-Yu Tsai <wens@csie.org>
    >
    > The devicetree binding lists the phy phy as optional. As such, the
    > driver should not bail out if it can't find a regulator. Instead it
    > should just skip the remaining regulator related code and continue
    > on normally.
    >
    > Skip the remainder of phy_power_on() if a regulator supply isn't
    > available. This also gets rid of the bogus return code.
    >
    > Fixes: 2e12f536635f ("net: stmmac: dwmac-rk: Use standard devicetree property for phy regulator")
    > Signed-off-by: Chen-Yu Tsai <wens@csie.org>

    Applied and queued up for -stable.

    > On a separate note, maybe we should add this file to the Rockchip
    > entry in MAINTAINERS?

    Yes, probably.

    Thanks.

    \
     
     \ /
      Last update: 2019-08-30 23:19    [W:4.990 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site