Messages in this thread | | | From | Ben Wei <> | Subject | Re: [PATCH net-next] net/ncsi: add response handlers for PLDM over NC-SI | Date | Fri, 30 Aug 2019 20:57:21 +0000 |
| |
> > This patch adds handlers for PLDM over NC-SI command response. > > > > This enables NC-SI driver recognizes the packet type so the responses don't get dropped as unknown packet type. > > > > PLDM over NC-SI are not handled in kernel driver for now, but can be passed back to user space via Netlink for further handling. > > > > Signed-off-by: Ben Wei <benwei@fb.com> > > I don't know why but patchwork puts part of your patch into the commit message, see: > > https://urldefense.proofpoint.com/v2/url?u=https-3A__patchwork.ozlabs.org_patch_1154104_&d=DwICAg&c=5VD0RTtNlTh3ycd41b3MUw&r=U35IaQ-> 7Tnwjs7q_Fwf_bQ&m=vxOIQa5Sv7aY4LKSUvlobJd_TtHOz1KLjxZw8WXmkJM&s=A8rpxgac6iuSEH2DqCSzBDdM82Eu3pD8_nGHx9YtGW8&e= > > It's probably an encoding issue or similar. > > > +static int ncsi_rsp_handler_pldm(struct ncsi_request *nr) { >> + return 0; > > +} > > + > > static int ncsi_rsp_handler_netlink(struct ncsi_request *nr) { > > I know other functions in this file do it, but please put the openning > curly braces of a function on a separate line. > > Thank you.
Thanks David. I think the issue is related to my email client setting. I fixed it and resubmitted a v2 version of this patch.
Thanks, -Ben
| |