Messages in this thread | | | Date | Fri, 30 Aug 2019 15:36:49 -0400 | From | "George G. Davis" <> | Subject | Re: [PATCH v2] selftests: watchdog: Add optional file argument |
| |
On Fri, Aug 30, 2019 at 10:20:23AM -0600, shuah wrote: > On 8/30/19 10:13 AM, George G. Davis wrote: > >On Fri, Aug 30, 2019 at 09:12:10AM -0600, shuah wrote: > >>Can you split this line into two printf's. Checkpatch doesn't like > >>it. > >> > >Sure, I'll add the following interdiff in v3: > > Thanks. This is what I am looking for. Please send v3 with thsi change.
Done.
> >>On a separate note, I wish this usage block uses \t instead of spacing > >>things out. > > > >I noticed that most of those lines are hard spaced with only one using tabs. > >To remain consistent with existing CodingStyle, I used hard spaces. > > > > yes. My comment about using "\t" can be done later and if you would like > to send for that patch, I will be happy to take it.
I'll send that along in a separate thread.
Thanks!
-- Regards, George
| |