Messages in this thread | | | Subject | Re: [PATCH] leds: Move static keyword to the front of declarations | From | Dan Murphy <> | Date | Fri, 30 Aug 2019 10:02:03 -0500 |
| |
Krzystof
Thanks for the patch
On 8/30/19 4:09 AM, Krzysztof Wilczynski wrote: > Move the static keyword to the front of declarations. > > In drivers/leds/leds-lm3532.c for ramp_table, als_avrg_table > and als_imp_table, and in drivers/leds/leds-lm3532.c for > ramp_table. > > This will resolve the following compiler warnings that can > be seen when building with warnings enabled (W=1): > > drivers/leds/leds-lm3532.c:209:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > drivers/leds/leds-lm3532.c:266:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > drivers/leds/leds-lm3532.c:281:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > drivers/leds/leds-ti-lmu-common.c:14:1: warning: > ‘static’ is not at beginning of declaration [-Wold-style-declaration] > > Signed-off-by: Krzysztof Wilczynski <kw@linux.com> > --- > Related: https://lore.kernel.org/r/20190827233017.GK9987@google.com > > drivers/leds/leds-lm3532.c | 6 +++--- > drivers/leds/leds-ti-lmu-common.c | 2 +-
This file is missing in the subject.
Maybe break it out into a separate patch since they do not have dependencies on each other.
Dan
| |