lkml.org 
[lkml]   [2019]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm: Remove NULL check in clear_hwpoisoned_pages()
From
Date
On 29.08.19 05:51, Alastair D'Silva wrote:
> There is no possibility for memmap to be NULL in the current
> codebase.
>
> This check was added in commit 95a4774d055c ("memory-hotplug:
> update mce_bad_pages when removing the memory")
> where memmap was originally inited to NULL, and only conditionally
> given a value.
>
> The code that could have passed a NULL has been removed, so there
> is no longer a possibility that memmap can be NULL.
>
> Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
> ---
> mm/sparse.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/sparse.c b/mm/sparse.c
> index 78979c142b7d..9f7e3682cdcb 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -754,9 +754,6 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages)
> {
> int i;
>
> - if (!memmap)
> - return;
> -
> /*
> * A further optimization is to have per section refcounted
> * num_poisoned_pages. But that would need more space per memmap, so
>

Reviewed-by: David Hildenbrand <david@redhat.com>

--

Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2019-08-30 16:04    [W:1.807 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site