Messages in this thread | | | Date | Fri, 30 Aug 2019 12:18:17 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] ASoC: es8316: Add clock control of MCLK |
| |
On Fri, Aug 30, 2019 at 02:32:04AM +0900, Katsuhiro Suzuki wrote:
> + es8316->mclk = devm_clk_get(component->dev, "mclk"); > + if (PTR_ERR(es8316->mclk) == -EPROBE_DEFER) > + return -EPROBE_DEFER;
If we don't get a clock it'd be nice to at least log that in case there's something wrong with the clock driver so that people have more of a hint as to why things might be breaking.
> + > + if (es8316->mclk) { > + ret = clk_prepare_enable(es8316->mclk); > + if (ret) > + return ret; > + } > +
There's nothing that disables the clock on remove.
Otherwise this looks good. [unhandled content-type:application/pgp-signature] | |