Messages in this thread | ![/](/images/icornerl.gif) | | From | Krishna Reddy <> | Subject | RE: [PATCH 3/7] iommu/arm-smmu: Add tlb_sync implementation hook | Date | Fri, 30 Aug 2019 22:49:21 +0000 |
| |
>> + if (smmu->impl->tlb_sync) { >> + smmu->impl->tlb_sync(smmu, page, sync, status);
>What I'd hoped is that rather than needing a hook for this, you could just override smmu_domain->tlb_ops from .init_context to wire up the alternate .sync method directly. That would save this extra level of indirection.
Hi Robin, overriding tlb_ops->tlb_sync function is not enough here. There are direct references to arm_smmu_tlb_sync_context(), arm_smmu_tlb_sync_global() functions. In arm-smmu.c. we can replace these direct references with tlb_ops->tlb_sync() function except in one function arm_smmu_device_reset(). When arm_smmu_device_reset() gets called, domains are not initialized and tlb_ops is not available. Should we add a new hook for arm_smmu_tlb_sync_global() or make this as a responsibility of impl->reset() hook as it gets called at the same place?
-KR
| ![\](/images/icornerr.gif) |