Messages in this thread | | | Date | Thu, 29 Aug 2019 16:32:22 +0200 | From | robin <> | Subject | Re: [PATCH v2 1/2] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q |
| |
On 2019-08-29 13:50, Marco Felsch wrote: > On 19-08-29 09:11, Robin Gong wrote: >> >> On 2019-08-29 16:17, Marco Felsch wrote: >> > > > While reading the rm it seems that >> > > > the snvs block has a dedicated version register. IMHO this could be >> > > > a better way to apply the change also to existing devices with old >> > > > firmware. >> > > >> > > I thought the same thing, and fully agree with you. However I do not >> > > have a way to determine which versions are out there. Since I couldn't >> > > find any documentation on this, and I only have i.MX6 S/DL, D/Q and UL >> > laying around. >> > >> > @NXP Kernel Team >> > Can we get some more information here? >> Go ahead, please. That snvs version register SNVS_HPVIDR1 should work >> as expect. >> MINOR_REV checking is enough, none-zero means for soc after i.mx6sx, >> but >> Zero means i.mx6q/dl/sl elder soc. > > Thanks. Robin can you integrate that so we can drop the different > dt-handling?
No problem, I'll post an updated patch tomorrow.
> > Regards, > Marco > >> > >> > Regards, >> > Marco >> > >> > > Regards, >> > > Robin van der Gracht >> > > >> > >> > -- >> > Pengutronix e.K. | >> > | >> > Industrial Linux Solutions | >> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p >> > engutronix.de%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7C8d4e1 >> > 0cd77bd4652f3eb08d72c594e76%7C686ea1d3bc2b4c6fa92cd99c5c301635%7 >> > C0%7C0%7C637026634390359345&sdata=mhXlUxmLWg8qtwhPQfkJZm >> > VAn4QQ3YybLOSh83uf27E%3D&reserved=0 | >> > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 >> > | >> > Amtsgericht Hildesheim, HRA 2686 | Fax: >> > +49-5121-206917-5555 | >>
| |