Messages in this thread | | | From | Parav Pandit <> | Subject | RE: [PATCH v1 1/5] mdev: Introduce sha1 based mdev alias | Date | Thu, 29 Aug 2019 09:07:11 +0000 |
| |
> -----Original Message----- > From: Alex Williamson <alex.williamson@redhat.com> > Sent: Thursday, August 29, 2019 3:05 AM > To: Parav Pandit <parav@mellanox.com> > Cc: Jiri Pirko <jiri@mellanox.com>; kwankhede@nvidia.com; > cohuck@redhat.com; davem@davemloft.net; kvm@vger.kernel.org; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org > Subject: Re: [PATCH v1 1/5] mdev: Introduce sha1 based mdev alias > > On Wed, 28 Aug 2019 15:25:44 -0600 > Alex Williamson <alex.williamson@redhat.com> wrote: > > > On Tue, 27 Aug 2019 14:16:50 -0500 > > Parav Pandit <parav@mellanox.com> wrote: > > > module_init(mdev_init) > > > diff --git a/drivers/vfio/mdev/mdev_private.h > b/drivers/vfio/mdev/mdev_private.h > > > index 7d922950caaf..cf1c0d9842c6 100644 > > > --- a/drivers/vfio/mdev/mdev_private.h > > > +++ b/drivers/vfio/mdev/mdev_private.h > > > @@ -33,6 +33,7 @@ struct mdev_device { > > > struct kobject *type_kobj; > > > struct device *iommu_device; > > > bool active; > > > + const char *alias; > > Nit, put this above active to avoid creating a hole in the structure. > Thanks, > Ack.
> Alex
| |