Messages in this thread | | | From | Mike Marshall <> | Date | Thu, 29 Aug 2019 21:28:12 -0400 | Subject | Re: [PATCH] orangefs: Add octal zero prefix |
| |
Thanks for catching this, I added this patch on top of Linux 5.3-rc6 and ran xfstests on orangefs with no regressions.
Acked-by: Mike Marshall <hubcap@omnibond.com>
-Mike
On Tue, Aug 13, 2019 at 6:54 AM Artur Świgoń <a.swigon@partner.samsung.com> wrote: > > This patch adds a missing zero to mode 755 specification required to > express it in octal numeral system. > > Reported-by: Łukasz Wrochna <l.wrochna@samsung.com> > Signed-off-by: Artur Świgoń <a.swigon@partner.samsung.com> > --- > fs/orangefs/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/orangefs/namei.c b/fs/orangefs/namei.c > index 1dd710e5f376..3e7cf3d0a494 100644 > --- a/fs/orangefs/namei.c > +++ b/fs/orangefs/namei.c > @@ -224,7 +224,7 @@ static int orangefs_symlink(struct inode *dir, > struct orangefs_object_kref ref; > struct inode *inode; > struct iattr iattr; > - int mode = 755; > + int mode = 0755; > int ret; > > gossip_debug(GOSSIP_NAME_DEBUG, "%s: called\n", __func__); > -- > 2.17.1 >
| |